GDB-7988: Avoid hardcoded classes #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the properties configmap
- Updated `deployment.imagePullSecret` to be a list, e.g. `deployment.imagePullSecrets` - Values from imagePullSecrets are now templated - Simplified the helper template for rendering imagePullSecrets
- Removed the default value from `global.imageRegistry`, the chart now uses the value from `images.graphdb.registry` - Added `images.graphdb.sha` to optionally provide an expected SHA checksum of the image - Simplified the helper template for rendering the GraphDB's image - Removed unused busybox image configurations from `images.busybox`
The chart will default to using the default storage class instead of using a hardcoded standard that might not be present in each cluster. - Added `graphdb.node.persistence.enabled` toggle flag for enabling or disabling the persistence of GraphDB - Removed `global.storageClass` in favor of using by default the default storage class in the cluster. Templates will no longer use `global.storageClass`. - Renamed `graphdb.clusterProxy.persistence.enablePersistence` toggle to just `enabled`
The ingress resource is no longer tied to the nginx controller.
- Added new configuration options for the default ingress `deployment.ingress`:
- Ability to override the `host` and `path` for GraphDB from `deployment.host`
and `graphdb.workbench.subpath`
- Changing the `pathType`
- Inserting additional hosts and TLS configurations with `extraHosts` and `extraTLS`
- Updated the ingress resource to be agnostic to the ingress implementation.
It will no longer assume that NGINX is the ingress controller in the cluster
- Removed `maxRequestSize` and `timeout` configurations from `deployment.ingress`
as they were specific to the ingress controller implementation of nginx
- Added `labels` for each service resource for insertion of additional labels - Added `containerPorts` and `proxy.containerPorts` for mapping the ports on which GraphDB listens on - Added `ports` mappings in each service - Added `extraContainerPorts` and `proxy.extraContainerPorts` - Service resources and probes now refer to the target ports by their nicknames - Renamed the port mappings of GraphDB and GraphDB proxy to `http` and `rpc` - Renamed `graphdb.node.service` to `headlessService`
mihailradkov
commented
Apr 8, 2024
yaskoo
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
propertiesfor inserting additional GraphDB configurations in the properties configmapworkbench.subpathto serve GraphDB at context path/by defaultdeployment.imagePullSecretto be a list, e.g.deployment.imagePullSecretsglobal.imageRegistry, the chart now uses the value fromimages.graphdb.registryimages.graphdb.shato optionally provide an expected SHA checksum of the imageimages.busyboxgraphdb.node.persistence.enabledtoggle flag for enabling or disabling the persistence of GraphDBglobal.storageClassin favor of using by default the default storage class in the cluster. Templates will no longer useglobal.storageClass.graphdb.clusterProxy.persistence.enablePersistencetoggle to justenableddeployment.ingress:- Ability to override the
hostandpathfor GraphDB fromdeployment.hostandgraphdb.workbench.subpath- Changing the
pathType- Inserting additional hosts and TLS configurations with
extraHostsandextraTLSmaxRequestSizeandtimeoutconfigurations fromdeployment.ingressas they were specific to the ingress controller implementation of nginxlabelsfor each service resource for insertion of additional labelscontainerPortsandproxy.containerPortsfor mapping the ports on which GraphDB listens onportsmappings in each serviceextraContainerPortsandproxy.extraContainerPortshttpandrpcgraphdb.node.servicetoheadlessService