-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Audio Improvements #1966
Conversation
Can you rebase it on the base dev branch instead of one including silver rupee shuffle and the like so it is easier to see the diffs? |
yeah I forgot that I had it on top of silver rupees. |
Still to do:
|
I started to write a guide for making custom banks https://gist.github.com/owlisnotacat1/e5445c154b46a9d7804b139800dfffbe |
…over multiple versions while continuing to support older versions custom music
.gitignore
Outdated
@@ -31,6 +31,7 @@ data/Models/Adult/*.zobj | |||
data/Models/Adult/Pieces | |||
data/Models/Child/*.zobj | |||
data/Models/Child/Pieces | |||
data/Music/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a separate .gitignore in data/Music for excluding .seq and .meta files. To keep the readme in the Music folder, .ootrs files should be added to that file instead of the entire folder here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm then I gotta figure out why any time I add custom music, git sees it as untracked... Anyway I'll do as you suggest. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 152/186 needs to be edited to use ootrs in the custom sequence exclusions file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does opening a draft PR basically just mean nothing 😐
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is not marked as a draft.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened it as a draft a month ago... just a bash as mracsys for not giving me a comment on it until I marked it ready.
@@ -1094,6 +1094,17 @@ def patch_music_changes(rom, settings, log, symbols): | |||
} | |||
} | |||
|
|||
# 7.2.0 | |||
patch_sets[0x1F073FDD] = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, forgot to submit this one with the others.
This conflicts with the patch set for ocarina note shuffle (#1885). Can this be incremented to 0x1F073FDE
to maintain consistency between patch files in test branches?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't make me hit you
This PR adds additional custom music capabilities to OOTR.
A general explanation of how this works on the technical side. Shout out to owl_is_not_a_cat (is a cat though), and the MMR folks for figuring this out:
I think that's the gist of it.
Would like to get some feedback on this one.