Fix metadata flush #342
Merged
Fix metadata flush #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmichal10
force-pushed
the
fix-metadata-flush
branch
from
7abad4a
to
2cf578f
Compare
Codecov Report
@@ Coverage Diff @@
## master #342 +/- ##
=========================================
Coverage ? 61.03%
=========================================
Files ? 81
Lines ? 9139
Branches ? 0
=========================================
Hits ? 5578
Misses ? 3561
Partials ? 0
|
mmichal10
force-pushed
the
fix-metadata-flush
branch
from
2cf578f
to
c74eb9a
Compare
robertbaldyga
previously approved these changes
Jan 23, 2020
arutk
reviewed
Jan 23, 2020
mmichal10
force-pushed
the
fix-metadata-flush
branch
from
c74eb9a
to
ddb010e
Compare
michalwy
requested changes
Jan 24, 2020
mmichal10
force-pushed
the
fix-metadata-flush
branch
3 times, most recently
from
3d6a24d
to
e8f2bd9
Compare
added 2 commits
January 24, 2020 11:27
After second dirty write to cache line which was already dirty, metadata flush was not triggered. In case of dirty shutdown, this led to data corruption. Signed-off-by: Michal Mielewczyk <michal.mielewczyk@intel.com>
In case of cleaning metadata used to be flushed only when status of whole cache line changed to clean. This patch ensures that metadata flush is triggered after changin status of each single sector is cache line. Signed-off-by: Michal Mielewczyk <michal.mielewczyk@intel.com>
mmichal10
force-pushed
the
fix-metadata-flush
branch
from
e8f2bd9
to
d9c987e
Compare
mariuszbarczak
approved these changes
Jan 24, 2020
michalwy
approved these changes
Jan 24, 2020
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Open-CAS/open-cas-linux#253