Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[packchk] missing component (Cvariant) not detected when specified in <accept> (M504:) #1052

Closed
jeromecoutant opened this issue Jul 10, 2023 · 4 comments
Closed

[packchk] missing component (Cvariant) not detected when specified in <accept> (M504:) #1052

jeromecoutant opened this issue Jul 10, 2023 · 4 comments
Assignees
@thorstendb-ARM
Labels
bug Something isn't working fixed Issue is fixed, please verify.

Comments

@jeromecoutant
Copy link
Contributor

jeromecoutant commented Jul 10, 2023 •
edited

Hi

Pdsc content:

    <condition id="xxx">
      <description>xxx</description>
      <require condition="xxx"/>
      <require Cclass="Device" Cgroup="STM32 HAL" Csub="Core"/>
      <accept Cclass="Device" Cgroup="STM32 HAL" Csub="timebases" Cvariant="NONE"/>
      <accept Cclass="Device" Cgroup="STM32 HAL" Csub="timebases" Cvariant="RTC_ALARM"/>
      <accept Cclass="Device" Cgroup="STM32 HAL" Csub="timebases" Cvariant="RTC_WKUP"/>
      <accept Cclass="Device" Cgroup="STM32 HAL" Csub="timebases" Cvariant="TIM"/>
    </condition>

    <component Cclass="Device" Cgroup="STM32 HAL" Csub="timebases" Cvariant="NONE" Cversion="0.1.0" condition="Timebase NONE">
...
    </component>

If some Cvariant are missing, there are no warning detecting this issue ?

Regards,
@jeromecoutant jeromecoutant added the bug Something isn't working label Jul 10, 2023
@thorstendb-ARM thorstendb-ARM self-assigned this Jul 10, 2023
@jkrech
Copy link
Member

jkrech commented Jul 11, 2023

@thorstendb-ARM
Does it make a difference whether <accept> or <require> is being used?

@jeromecoutant
Copy link
Contributor Author

jeromecoutant commented Jul 11, 2023 •
edited

Does it make a difference whether accept or require is being used?

Yes!
I replace accept by require and got message like
M504: RTE Model reports: MISSING: -- require Device:STM32 HAL:timebases:RTC_WKUP

@thorstendb-ARM
Copy link
Collaborator

M504 reports the internal RTE Model checks. We should extend PackChk:
Find all references and check if they are available (WARNING if not)

@jkrech jkrech changed the title [packchk] missing cvariant not detected [packchk] missing component (Cvariant) not detected when specified in <accept> (M504:) Jul 11, 2023
grasci-arm pushed a commit to ARM-software/devtools that referenced this issue Jul 12, 2023
@thorstendb-ARM
[packchk] missing component (Cvariant) not detected when specified in…
ed1527e 
… <accept> (M504:) Open-CMSIS-Pack#1052 (Open-CMSIS-Pack#650)

* [packchk] missing component (Cvariant) not detected when specified in <accept> (M504:) Open-CMSIS-Pack#1052

added missing checks
added test cases
@grasci-arm grasci-arm mentioned this issue Jul 12, 2023
Merged
@thorstendb-ARM thorstendb-ARM added the fixed Issue is fixed, please verify. label Jul 12, 2023
edriouk pushed a commit that referenced this issue Jul 13, 2023
@grasci-arm @thorstendb-ARM
[packchk] missing component (Cvariant) not detected when specified in…
3e6154d 
… <accept> (M504:) #1052 (#650) (#1061)

* [packchk] missing component (Cvariant) not detected when specified in
<accept> (M504:) #1052

added missing checks
added test cases

Co-authored-by: Thorsten de Buhr <thorstendb-ARM@users.noreply.github.com>
@jkrech
Copy link
Member

jkrech commented Jul 18, 2023

@thorstendb-ARM can you please provide a version for @jeromecoutant to test the fix?

@jkrech jkrech closed this as completed Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thorstendb-ARM thorstendb-ARM

Labels
bug Something isn't working fixed Issue is fixed, please verify.
Projects
No open projects
CMSIS-Toolbox 2.1
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jkrech @edriouk @jeromecoutant @thorstendb-ARM