[packchk] missing component (Cvariant) not detected when specified in <accept> (M504:) #1052 (#650) #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… <accept> (M504:) Open-CMSIS-Pack#1052 (Open-CMSIS-Pack#650) * [packchk] missing component (Cvariant) not detected when specified in <accept> (M504:) Open-CMSIS-Pack#1052 added missing checks added test cases
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1061 +/- ##
==========================================
+ Coverage 54.61% 55.05% +0.43%
==========================================
Files 116 116
Lines 22703 22713 +10
Branches 12607 12613 +6
==========================================
+ Hits 12400 12505 +105
+ Misses 8148 8032 -116
- Partials 2155 2176 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
|
edriouk
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<accept>(M504:) #1052added missing checks
added test cases