Integrated code from device generator #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thorstendb-ARM
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Implementation looks great. As discussed, code was moved to new modules(s).
Regarding tests: Please review/add functional tests that we can see if something breaks or changes in CubeMX generated files (e.g. parsing of C and MX files). You can also use the "--read" functionality for that.
We will not meet the 80+%, as the current bridge main branch also does not meet it. In addition to that there is the go issue, that for coverage tests only the "current" module is taken into account but not others in the call tree.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a "merge" with the Python tool "MX_Device_Generator"