Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0033749: Configuration - Update permission draw.sh #15

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

ThmsP
Copy link
Contributor

@ThmsP ThmsP commented Feb 26, 2024

Hello,
Currently, the file draw.sh is installed with very open permissions (777).
This is probably not a problem for a user installation but we package it with rpm and thus it leaves a root owned file with very insecure permissions.
I have a very limited view of the project thus I may be missing the point of this permissions.

Limit draw.sh permission to 755 instead of 777
@dpasukhi
Copy link
Contributor

Hello, thank you for the patch. We will analyze it.
Our main bug tracker is https://tracker.dev.opencascade.org/my_view_page.php
PR in OCCT for read only.

@dpasukhi
Copy link
Contributor

@ThmsP There an new issue for your ticket https://tracker.dev.opencascade.org/view.php?id=33749
We will proceed with your PR after your signing CLA - https://dev.opencascade.org/get_involved
_
OCCT GitHub repo going to have write access.

@dpasukhi dpasukhi changed the title Update permission draw.sh 0033749: Configuration - Update permission draw.sh Jun 27, 2024
@dpasukhi dpasukhi self-requested a review June 27, 2024 10:59
@dpasukhi dpasukhi added the 2. Bug Something isn't working label Jun 27, 2024
@ThmsP
Copy link
Contributor Author

ThmsP commented Jun 27, 2024

@dpasukhi : Hello, I just signed and send the CLA.

@dpasukhi dpasukhi changed the base branch from master to IR-1 June 27, 2024 17:30
@dpasukhi
Copy link
Contributor

Great. I will initiate the test procedure.
After full test cycle the issue will be integrated into IR-1 then it will be integrated into master.

@dpasukhi
Copy link
Contributor

Tests are success:
http://jenkins-test-10.nnov.opencascade.com/view/CR33752-master-dpasukhi/view/COMPARE/

@dpasukhi dpasukhi merged commit 531b9e6 into Open-Cascade-SAS:IR-1 Jun 28, 2024
@ThmsP
Copy link
Contributor Author

ThmsP commented Jun 28, 2024

Thanks !

@dpasukhi
Copy link
Contributor

@ThmsP the CLA was filled up with some mistakes.
I will keep changes in IR branch for some time waiting for your CLA update.

@dpasukhi
Copy link
Contributor

dpasukhi commented Jul 4, 2024

@ThmsP if you mind to share your personal data.
Could I change the author of this comment to OpenCascade? I have no option to allow merge your commit without correct CLA :(

@ThmsP
Copy link
Contributor Author

ThmsP commented Jul 4, 2024

@dpasukhi Sorry, I just send a correctly filled form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. Configuration 2. Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants