minor bug fix, updated documentation with user account creation guide #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request. Unfortunetaly, I think the PR won't work as proposed. The name specified during registration is not used anywhere else you'd still need to log-in with the actual id. We'll probably fix this behavior in the future and come back to your PR then, but it's likely not anytime soon. I'm aware that there's a vulnerability reported by npm for the earthengine-api, but npm audit fix doesn't fix it correctly as it's not fixed in the earthengine-api yet. See https://github.com/google/earthengine-api/issues/103. Maybe there's another one that I'm not aware of yet as I'm still on node 11. |
|
I appreciate you reverted. Thank you. |
|
Closing in favor of the new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noted node 12.x raises a high vulnerability concern which ain't raised on node 10.x. However, npm audit fix clears them all.