Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #126: use real user id in batch jobs instead of proxy user id #128

Merged
merged 2 commits into from
Mar 9, 2022
Merged

Fix #126: use real user id in batch jobs instead of proxy user id #128

merged 2 commits into from
Mar 9, 2022

Conversation

soxofaan
Copy link
Member

@soxofaan soxofaan commented Feb 25, 2022 •
edited
Loading

see #126

openEO processing in batch jobs needs real user id for load_result and UDPs to work properly.
Proxy user id is just necessary when submitting the job.

@soxofaan
Fix #126: use real user id in batch jobs instead of proxy user id
7c31bd0 
openEO processing in batch jobs needs real user id
for `load_result` and UDPs to work properly.
Proxy user id is just necessary when submitting the job.
@soxofaan soxofaan requested a review from bossie February 25, 2022 09:19
@soxofaan
Copy link
Member Author

@bossie do you think this is going to work?

bossie
bossie requested changes Mar 8, 2022
View reviewed changes
Copy link
Collaborator

@bossie bossie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the "${proxyUser}" argument to batch_job.py as it is not needed.

openeogeotrellis/deploy/batch_job.py Outdated Show resolved Hide resolved
openeogeotrellis/deploy/submit_batch_job.sh Outdated Show resolved Hide resolved
openeogeotrellis/deploy/submit_batch_job_spark24.sh Outdated Show resolved Hide resolved
openeogeotrellis/deploy/submit_batch_job_spark3.sh Outdated Show resolved Hide resolved
@soxofaan
Issue #126: drop proxy user id from batch job
011f20a 
PR #128 follow up: no need to keep proxy user id in batch job itself

also be more simple/strict in `argv` handling batch_job.py
@soxofaan
Copy link
Member Author

soxofaan commented Mar 9, 2022

yes indeed, I didn't see proxyUser being used in batch_job.py, but I wanted to be sure it was fine to remove/replace it

@soxofaan soxofaan merged commit 6827cff into master Mar 9, 2022
@soxofaan soxofaan deleted the issue126-load-result-user-id branch March 9, 2022 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bossie bossie bossie requested changes

Assignees

@bossie bossie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@soxofaan @bossie