Quantiles: Clarify to use type 7 #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-mohr
requested review from
edzer,
jdries,
aljacob,
metzm,
dthiex and
SerRichard
Closed
Closed
dthiex
requested changes
Nov 18, 2021
dthiex
approved these changes
Nov 18, 2021
m-mohr
commented
Nov 22, 2021
m-mohr
commented
Nov 22, 2021
|
Last chance to review, I plan to merge this on Wednesday! |
|
In quantiles.json: at the end of description there is S, did you mean JS? |
|
@clausmichele No, it refers to the programming language S :) |
|
Thanks, I've learned something new today :) |
clausmichele
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #296
From what I read in #296, it seems only VITO would need to switch from "Legacy" to R_7 in their library and Sinergise would need to switch from "higher" to "linear". All other implementations seem to implement type 7 already.
I've not chosen to go for a list yet and only clarify the type for now. If there's demand for more types, we can add that later.