Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modern Settings shortcuts are broken on my install #1031

Closed
terax6669 opened this issue May 28, 2022 · 4 comments
Closed

Modern Settings shortcuts are broken on my install #1031

terax6669 opened this issue May 28, 2022 · 4 comments
Assignees
Labels
Windows 11 Issues related to Windows 11.

Comments

@terax6669
Copy link

To Reproduce
Steps to reproduce the behavior:

  1. Open start, search for windows updates
  2. Click on "Check for updates"
  3. Windows settings open, but not the update tab.

Expected behavior
The shortcut takes us to the expected location.

Screenshots
image

Version:

  • Open-Shell: 4.4.160 and 4.4.170
  • OS: Windows 11 Pro 21H2 22000.675

Additional context
I've noticed that the action is doubled.
image
I think they're called AAA_SystemSettings_MusUpdate_UpdateActionButton and AAA_SystemSettings_MusUpdate_UpdateActionButton-2. The second one works for me. As you can see there are other duplicates there and other weird entries too...
image

@ge0rdi ge0rdi changed the title Open-Shell Modern Settings shortcuts are broken on my install Modern Settings shortcuts are broken on my install Nov 19, 2022
@ge0rdi ge0rdi added the Windows 11 Issues related to Windows 11. label Nov 19, 2022
@ge0rdi ge0rdi self-assigned this Dec 10, 2022
@ge0rdi
Copy link
Member

ge0rdi commented Dec 10, 2022

Just note that Windows started to add new settings descriptions and keep old ones (for whatever reason).
That's why we should those duplicates.

I'll try to remove duplicate ones and keep those newer (better) ones (with the numeric suffix).

ge0rdi added a commit that referenced this issue Dec 21, 2022
Windows started to add newer version of settings to settings description
file. These have the same description as older settings, but use
different parameters.

Unfortunately old settings are still present.
This causes our modern settings folder to contain duplicates.
And also we tend to use older setting definitions that no longer work
properly.

Thus we will de-duplicate parsed settings and try to keep newer ones
(that should work better).
New settings tend to have numeric suffix, so we will keep those with
biggest suffix.

Fixes #1031
ge0rdi added a commit that referenced this issue Dec 21, 2022
Windows started to add newer version of settings to settings description
file. These have the same description as older settings, but use
different parameters.

Unfortunately old settings are still present.
This causes our modern settings folder to contain duplicates.
And also we tend to use older setting definitions that no longer work
properly.

Thus we will de-duplicate parsed settings and try to keep newer ones
(that should work better).
New settings tend to have numeric suffix, so we will keep those with
biggest suffix.

Fixes #1031
ge0rdi added a commit that referenced this issue Dec 23, 2022
Windows started to add newer version of settings to settings description
file. These have the same description as older settings, but use
different parameters.

Unfortunately old settings are still present.
This causes our modern settings folder to contain duplicates.
And also we tend to use older setting definitions that no longer work
properly.

Thus we will de-duplicate parsed settings and try to keep newer ones
(that should work better).
New settings tend to have numeric suffix, so we will keep those with
biggest suffix.

Fixes #1031
ge0rdi added a commit that referenced this issue Dec 23, 2022
Windows started to add newer version of settings to settings description
file. These have the same description as older settings, but use
different parameters.

Unfortunately old settings are still present.
This causes our modern settings folder to contain duplicates.
And also we tend to use older setting definitions that no longer work
properly.

Thus we will de-duplicate parsed settings and try to keep newer ones
(that should work better).
New settings tend to have numeric suffix, so we will keep those with
biggest suffix.

Fixes #1031
ge0rdi added a commit that referenced this issue Dec 24, 2022
Windows started to add newer version of settings to settings description
file. These have the same description as older settings, but use
different parameters.

Unfortunately old settings are still present.
This causes our modern settings folder to contain duplicates.
And also we tend to use older setting definitions that no longer work
properly.

Thus we will de-duplicate parsed settings and try to keep newer ones
(that should work better).
New settings tend to have numeric suffix, so we will keep those with
biggest suffix.

Fixes #1031
ge0rdi added a commit that referenced this issue Dec 25, 2022
Windows started to add newer version of settings to settings description
file. These have the same description as older settings, but use
different parameters.

Unfortunately old settings are still present.
This causes our modern settings folder to contain duplicates.
And also we tend to use older setting definitions that no longer work
properly.

Thus we will de-duplicate parsed settings and try to keep newer ones
(that should work better).
New settings tend to have numeric suffix, so we will keep those with
biggest suffix.

Fixes #1031
ge0rdi added a commit that referenced this issue Dec 27, 2022
Windows started to add newer version of settings to settings description
file. These have the same description as older settings, but use
different parameters.

Unfortunately old settings are still present.
This causes our modern settings folder to contain duplicates.
And also we tend to use older setting definitions that no longer work
properly.

Thus we will de-duplicate parsed settings and try to keep newer ones
(that should work better).
New settings tend to have numeric suffix, so we will keep those with
biggest suffix.

Fixes #1031
@ge0rdi ge0rdi closed this as completed in 2a7fc00 Dec 28, 2022
@ge0rdi
Copy link
Member

ge0rdi commented Dec 28, 2022

Should be fixed in latest build.

@terax6669
Copy link
Author

It took a while to populate the settings the first time I used the search, but it seems to be working great now 👍

@ge0rdi
Copy link
Member

ge0rdi commented Dec 30, 2022

Yup, first time the modern settings folder is enumerated it has to retrieve localized strings for all the settings. It takes some time. But then it is cached so subsequent searches are fast.

Thanks for confirming it works for you now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Windows 11 Issues related to Windows 11.
Projects
None yet
Development

No branches or pull requests

2 participants