Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need more explicit control over text size #1110

Closed
pderocco opened this issue Aug 21, 2022 · 7 comments · Fixed by #1294
Closed

Need more explicit control over text size #1110

pderocco opened this issue Aug 21, 2022 · 7 comments · Fixed by #1294
Assignees
@ge0rdi

Comments

@pderocco
Copy link

I have a 17" laptop with a 3840x2160 display. The Display Scaling in Windows is set to 150%, which still leaves text quite small, but if I wanted big text I wouldn't have wasted money on that display. The text in the Start menu, however, is much larger than the text everywhere else. Changing "Override system DPI" over the range from 96 to 480 only varies it a little bit.

If there is some reason that the 5:1 range of "Override system DPI" doesn't produce a 5:1 variation in text size, then we need an alternative way to specify the sizes. I don't really care how it is specified, as for me it is a "set-it-and-forget-it" option.

This shows the huge difference between the text size in the Start menu and the text size in the Open-Shell settings dialog. The smaller size is what I want.

Untitled
@pderocco pderocco added the Enhancement/Feature Request An Enhancement/Feature request by the community label Aug 21, 2022
@blackcrack

This comment was marked as off-topic.

Sign in to view
@CTVCAM8
Copy link

CTVCAM8 commented Aug 23, 2022

Something isn't tracking correctly.

Could be related to Windows system options like Ease of Access display settings "Make text bigger",
or the % scaling not tracking with Open-Shell.

Restarting Open-Shell with "Override system DPI" back to the default setting "0", so it tracks the 150% system size should work.

If that doesn't do anything,
you could try the "Metallic" skin, and adjust the built-in "Text size" option to say "8".

If that does not work either, something really is buggy.

@blackcrack
Copy link

grafik

grafik

@bonzibudd
Copy link
Member

In the Classic theme, Open-Shell follows the font information specified by Windows, and it does not override the size like other skins. So because of that, when you use "Override DPI," the font size doesn't change because the system font hasn't changed.

Are any other apps behaving in a similar way? It's possible that Open-Shell is using an uncommon font metric to determine the size, so it still looks normal in most interfaces.

@bonzibudd bonzibudd added the Windows bug Something isn't working right (possibly) specific to the Windows OS... label Jan 7, 2023
@ge0rdi
Copy link
Member

ge0rdi commented Jan 7, 2023

In the Classic theme, Open-Shell follows the font information specified by Windows, and it does not override the size like other skins.

That's right.
Since there is no font specified in Classic Skin, we are using default system font.
But we don't scale font size according to DPI (whether system/monitor one or the override in settings).

Will fix that soon.

@ge0rdi ge0rdi self-assigned this Jan 7, 2023
@ge0rdi ge0rdi removed Windows bug Something isn't working right (possibly) specific to the Windows OS... Enhancement/Feature Request An Enhancement/Feature request by the community labels Jan 7, 2023
ge0rdi added a commit that referenced this issue Jan 8, 2023
@ge0rdi
Properly scale default skin font according to DPI (#1110)
03f2191 
If skin doesn't specify font to be used (such as `Classic Skin`) we will
use default system font (used for menus).

But we didn't scale the font size according to DPI.
This commit will fix that.

Fixes #1110
@ge0rdi ge0rdi mentioned this issue Jan 8, 2023
Merged
ge0rdi added a commit that referenced this issue Jan 8, 2023
@ge0rdi
Properly scale default skin font according to DPI (#1110)
05779ca 
If skin doesn't specify font to be used (such as `Classic Skin`) we will
use default system font (used for menus).

But we didn't scale the font size according to DPI.
This commit will fix that.

Fixes #1110
@ge0rdi ge0rdi closed this as completed in 528d15e Jan 13, 2023
ge0rdi added a commit that referenced this issue Jan 18, 2023
@ge0rdi
Properly scale default skin font according to DPI (#1110)
f44594a 
Original fix introduced in 528d15 was not correct.
The problem is that `SystemParametersInfo` uses DPI that current session
started with.

We should use `SystemParametersInfoForDpi` (available since Win10 1607)
that returns properly scaled font size.

Fixes #1110
@ge0rdi ge0rdi mentioned this issue Jan 18, 2023
Merged
@ge0rdi
Copy link
Member

ge0rdi commented Jan 18, 2023

Original fix in 4.4.188 wasn't correct, so we are working on (hopefully) proper fix.

@ge0rdi ge0rdi reopened this Jan 18, 2023
ge0rdi added a commit that referenced this issue Jan 19, 2023
@ge0rdi
Properly scale default skin font according to DPI (#1110)
21eea53 
Original fix introduced in 528d15 was not correct.
The problem is that `SystemParametersInfo` uses DPI that current session
started with.

We should use `SystemParametersInfoForDpi` (available since Win10 1607)
that returns properly scaled font size.

Fixes #1110
@ge0rdi
Copy link
Member

ge0rdi commented Jan 19, 2023

4.4.189 should contain proper fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ge0rdi ge0rdi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Properly scale default skin font according to DPI (#1110) Open-Shell/Open-Shell-Menu
5 participants
@ge0rdi @blackcrack @pderocco @CTVCAM8 @bonzibudd