Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed options are not displayed in bold (Classic Explorer) #1135

Closed
w64bit opened this issue Sep 10, 2022 · 3 comments
Closed

Changed options are not displayed in bold (Classic Explorer) #1135

w64bit opened this issue Sep 10, 2022 · 3 comments

Comments

@w64bit
Copy link

w64bit commented Sep 10, 2022 •
edited

Describe the bug
Changed options are not anymore displayed in bold in Classic Explorer

Version:
Open-Shell 4.4.177
Windows 10 21H2, 22H2, x64

Additional context
4.4.169 it's OK
@ge0rdi
Copy link
Member

ge0rdi commented Sep 11, 2022

Can you provide a screenshot for clarification?

Is the setting displayed as bold if you change it to other than default value?

4.4.169 it's OK

What about latest official version 4.4.170?

ge0rdi added a commit to ge0rdi/Open-Shell-Menu that referenced this issue Sep 11, 2022
@ge0rdi
Revert "Auto-detect when setting is back to default value"
0556bff 
This reverts commit 998d83c.

This change was wrong and it shouldn't get merged in first place.
See Open-Shell#829 (comment) for further explanation.

Fixes Open-Shell#1135.
@ge0rdi
Copy link
Member

ge0rdi commented Sep 11, 2022

Hmm, I think I've got it.
Recent (rather unfortunate) change caused settings that were manually changed to default value to be not highlighted.

I will revert the change (see #1138).

@blackcrack
Copy link

@w64bit
test it out if works, close this issue :)
https://ci.appveyor.com/project/passionate-coder/open-shell-menu/builds/44742237

big thanks @ge0rdi

best

@ge0rdi ge0rdi closed this as completed in 179a59a Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ge0rdi @blackcrack @w64bit