Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show first-time settings dialog if settings were imported from XML already #1319

Closed
daiaji opened this issue Jan 31, 2023 · 5 comments
Closed
Assignees
Labels
Enhancement/Feature Request An Enhancement/Feature request by the community

Comments

@daiaji
Copy link

daiaji commented Jan 31, 2023

Is your feature request related to a problem? Please describe.

#118 #251 #630 #9

Basically, after importing Open-Shell configurations using the -xml parameter, Open-Shell will not use these configurations in a non-interactive way.

Describe the solution you'd like

When the -xml parameter is used, Open-Shell-Menu automatically adds these key values to the registry.
REG ADD "HKCU\Software\OpenShell\StartMenu" /v "ShowedStyle2" /t REG_DWORD /d "1" /f
To be honest, this will not be particularly difficult, even without making major changes to the existing process. Just add a step of rewriting the registry to the implementation of the -xml parameter. Just doing this will make the command line operation experience better.

Especially when I use Open-Shell-Menu in Windows PE, I usually need to import Open-Shell-Menu configuration from the command line in batch processing, but it is not particularly convenient to edit the registry in Windows PE. Moreover, since Windows PE usually does not include any form of start menu component, Open-Shell-Menu is almost necessary. I hope Open-Shell-Menu provides portable application packaging for users, In this way, I don't need to install Open-Shell-Menu in the bare metal system when integrating Open-Shell-Menu for Windows PE.

Area of issue

Start menu

Alternatives you've considered

Add the registry manually.

Additional context

No response

@daiaji daiaji added the Enhancement/Feature Request An Enhancement/Feature request by the community label Jan 31, 2023
@ge0rdi
Copy link
Member

ge0rdi commented Jan 31, 2023

Basically, after importing Open-Shell configurations using the -xml parameter, Open-Shell will not use these configurations in a non-interactive way.

Can you please explain what you mean by that?

-xml command line parameter should import settings that are stored in given XML and after that these settings should be used by Open-Shell the same way as if one set them via settings dialog.

To be honest, this will not be particularly difficult, even without making major changes to the existing process.

If you already know what it takes and how to achieve what you need, you can submit pull-request with required changes.

I hope Open-Shell-Menu provides portable application packaging for users, In this way, I don't need to install Open-Shell-Menu in the bare metal system when integrating Open-Shell-Menu for Windows PE.

Have you tried to copy Open-Shell install folder from machine where it is installed to machine where you need to use it?
It seems to be working for me.

@daiaji
Copy link
Author

daiaji commented Jan 31, 2023

Can you please explain what you mean by that?

Screenshot_20230131_224813

Even if you use the -xml parameter to import the configuration backup, this pop-up window will pop up the first time you use the command line to start Open-Shell-Menu. Of course, it won't be the second time you start Open-Shell-Menu, because Open-Shell-Menu will fill in the registry when you start Open-Shell-Menu for the first time.
REG ADD "HKCU\Software\OpenShell\StartMenu" /v "ShowedStyle2" /t REG_DWORD /d "1" /f

If you already know what it takes and how to achieve what you need, you can submit pull-request with required changes.

Although I know the principle, I am not familiar with C++.

Have you tried to copy Open-Shell install folder from machine where it is installed to machine where you need to use it?
It seems to be working for me.

Of course, this is what I do now, so I have to install Open-Shell Menu on my bare metal first.
I want the zip package of the Open-Shell-Menu executable file, because my bare metal Win10 does not need Open-Shell-Menu, but WinPE does.

@ge0rdi
Copy link
Member

ge0rdi commented Jan 31, 2023

Even if you use the -xml parameter to import the configuration backup, this pop-up window will pop up the first time you use the command line to start Open-Shell-Menu.

Oki, so the problem is that the settings window is shown on first Open-Shell menu invoke, even if there were settings imported.

I guess it would make sense to not show the dialog if there were some settings imported already.

Of course, this is what I do now, so I have to install Open-Shell Menu on my bare metal first.

You can install it once (even in VM) and then just copy files, create ZIP package and just use it as many times as you want.

Though feel free to create separate enhancement issue for the portable package.
It is always easier to track just one enhancement in one ticket.

@daiaji
Copy link
Author

daiaji commented Jan 31, 2023

Though feel free to create separate enhancement issue for the portable package.
It is always easier to track just one enhancement in one ticket.

I will do it tomorrow.

@ge0rdi ge0rdi changed the title Perfect the command line parameter -xml,and provide portable application packaging. Don't show first-time settings dialog if settings were imported from XML already Feb 1, 2023
@ge0rdi ge0rdi self-assigned this Feb 4, 2023
@ge0rdi
Copy link
Member

ge0rdi commented Jul 24, 2023

Fixed in 4.4.190 .

@ge0rdi ge0rdi closed this as completed Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement/Feature Request An Enhancement/Feature request by the community
Projects
None yet
Development

No branches or pull requests

2 participants