Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual hex color input wrongly changes red and blue #82

Closed
ghost opened this issue Sep 15, 2018 · 10 comments
Closed

Manual hex color input wrongly changes red and blue #82

ghost opened this issue Sep 15, 2018 · 10 comments

Comments

@ghost
Copy link

ghost commented Sep 15, 2018

For example, if I set taskbar color to FF0000, it becomes blue instead of red. The first two and last two digits are switched in the final output.

@CTVCAM8
Copy link

CTVCAM8 commented Oct 14, 2018

Original developer has this on the old forum:

'Some programs show colors in RRGGBB order and some show them as BBGGRR order.
The start menu settings use BBGGRR order because that's what Windows is using.'
http://msdn.microsoft.com/en-us/library/dd183449(v=vs.85).aspx

@Ibuprophen
Copy link
Member

Ibuprophen commented Oct 14, 2018

I believe that the taskbar uses the $SystemAccentDark2 or $SystemAccentDark3 color depending if it is transparent or not. You can try changing the menu to
Main_bitmap=$SystemAccentDark2

Regarding the the colors for this software, I believe that they're expressed in specific Hex values and one popular place to look-up the hex values for the color you want is to use is "https://www.w3schools.com/colors/colors_picker.asp" and make sure the text color and background color are not the same, otherwise the text will be unreadable.

I hope that I had helped to clarify this better via text... :-)

Good Luck!

~Ibuprophen

@CTVCAM8
Copy link

CTVCAM8 commented Oct 14, 2018

override color
Hello Ibuprophen
As some of us are not programmers, we may not describe requests in the exact fashion required here. :)

zorbakus is describing what happens when 'taskbar color' is changed with a hex value entered into the shell settings.
This overrides the Windows taskbar color.
zorbakus is asking for the hex number to follow the standard format for most programs.
RRGGBB not BBGGRR.

It's the same issue with menu 'Overide glass color'.
If one wants to copy a hex color from another program, say Adobe, or 3schools link,
and paste that into taskbar color it turns opposite of what is to be expected.
FF0000 which is red on web page will now became blue in the shell program.

From what I gather from the links I supplied, looks like Ivo used
'COLORREF' 0x00bbggrr instead of 'RGBQUAD'
It would be swell if RGBQUAD or BGR to RGB C++ macro be incorporated into this shell program so everthing jives.

@Ibuprophen
Copy link
Member

I believe that the color should be entered as "#FF0000"...

~Ibuprophen

@CTVCAM8
Copy link

CTVCAM8 commented Oct 15, 2018

If the # is added along with the hex number, looks like it rejects the entry and defaults taskbar to black color 000000.
I'm not using the latest build. Was it upgraded already?

The hash symbol # has to be used in making menu skins though.
Those colors match the RedRedGreenGreenBlueBlue format and work perfectly in the skins.
That area does not require a color reversal.

The red and blue get switched on just the color pickers for override Taskbar/Menu color whenever a hex number is entered in the box.

@Ibuprophen
Copy link
Member

I do know that there's a handful of other circumstances that can result in this. I do apologize for providing possible solutions that reflects this one at a time.

I do know that the transparency feature being used as well can also affect the results of a color.

~Ibuprophen

@CTVCAM8
Copy link

CTVCAM8 commented Oct 15, 2018

Yes, transparency, glass blur, acrylic blur complicates further due to the mixing of desktop colors behind the taskbar/menu. What zorbakus and I are talking about is the basic opaque color.

I, aka juniper7 had mentioned similar issue about inputting a hex number in The Classic Shell forum way back

http://classicshell.net/forum/viewtopic.php?f=7&t=2666&hilit=colors+in+RRGGBB

It just kind of bugs me that separate color pickers example: Color Cop, NZ software Hex color finder can have it work as photo editors do. I suspect due to the complexity of the shell menu program, changing one thing could mess up a lot of other things and would not be worth it for the few people like zorbakus and me who actually use color override features.
Then again hey, it's not just one developer with Open Shell. Now it's the whole world of developers. :)

@scw2wi
Copy link

scw2wi commented Dec 9, 2021

When I'm installing the SW on Windows 11, the default color blue (141DC2) is shown as red (C2141D).
I think this is not intended and looks similar like this old reported bug.
And the next thing is, changing the color in the settings does not change the menu color at all.
Can it be, that this old bug still exists in Version 4.4.160?

@scw2wi
Copy link

scw2wi commented Jun 10, 2022

Also with Version 4.4.170 I'm still having the same problem under Windows 11,
that the "Menu Look / Override glass color" does not change the Menu glass color.
Whatever I'm selecting, the menu is red in all the cases.
Is this problem or any solution known?

ge0rdi added a commit to ge0rdi/Open-Shell-Menu that referenced this issue Nov 30, 2022
We are storing color settings in BBGGRR format (for historical reasons).
This may be confusing for people that are used to (more widely used) RRGGBB format.

Thus we will present color settings in RRGGBB format when editing.

We will still use BBGGRR format for those settings internally. To
maintain backward compatibility with existing settings stored in
registry/xml.

Also setting descriptions now contain hint about expected color format.
This way it should be more clear what values `Open-Shell` expects.

Fixes Open-Shell#82, Open-Shell#1141.
@ge0rdi ge0rdi closed this as completed in cef27bd Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants