Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unknown icons on right side when small #980

Closed
0penrc opened this issue Mar 6, 2022 · 1 comment · Fixed by #1088
Closed

Unknown icons on right side when small #980

0penrc opened this issue Mar 6, 2022 · 1 comment · Fixed by #1088
Assignees
@Ibuprophen
Labels
medium priority Non-critical but desired fix

Comments

@0penrc
Copy link

0penrc commented Mar 6, 2022

Describe the bug
There are a ton of unknown icons on the right side, when the skin makes them small for just the right side.

Go to the screenshots to see this bug.

To Reproduce
Steps to reproduce the behavior:

  1. Use the skin below
  2. Go to Open-Shell settings
  3. Apply it
  4. Turn on small icons

Expected behavior
The icons should appear as it should, like in Classic Shell 4.3.0. (see screenshots)

Screenshots
Unknown icons
image
Expected behavior
image

Version:

  • Open-Shell: 4.4.169
  • OS: Windows 10 1607 (LTSB 2016)

**Skin: **
Windows XP Classic.zip
@bonzibudd
Copy link
Member

Related to #561

among-us-official added a commit to among-us-official/Open-Shell-Menu that referenced this issue Aug 9, 2022
@among-us-official
Fix corrupted icons in second column
697ac4c 
Using skin with a different second column icon size, the icons would
become blank until 'Small icons' was toggled on and off;  restarting
turned them blank again.

The bool m_bTwoColumns is set after AddStandardItems, and is still
false since the constructor. As a workaround, use the value it is
assigned from InitWindowInternal instead.

Fix Open-Shell#980
among-us-official added a commit to among-us-official/Open-Shell-Menu that referenced this issue Aug 10, 2022
@among-us-official
Fix corrupted icons in second column
ec4f467 
When using skin with a different second column icon size, all of the
icons in it would become blank.

Because m_bTwoColumns is set after AddStandardItems, it is still false
in the column break check. As a workaround, use the value it's assigned
later in InitWindowInternal instead.

Fix Open-Shell#980
@among-us-official among-us-official mentioned this issue Aug 10, 2022
Merged
Ibuprophen pushed a commit that referenced this issue Aug 11, 2022
@among-us-official
Fix corrupted icons in second column (#1088)
b89aaed 
When using skin with a different second column icon size, all of the
icons in it would become blank.

Because m_bTwoColumns is set after AddStandardItems, it is still false
in the column break check. As a workaround, use the value it's assigned
later in InitWindowInternal instead.

Fix #980
@Ibuprophen Ibuprophen self-assigned this Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ibuprophen Ibuprophen

Labels
medium priority Non-critical but desired fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix corrupted icons in second column among-us-official/Open-Shell-Menu
3 participants
@Ibuprophen @bonzibudd @0penrc