New artwork for Open-Shell

[bonzibudd]

This adds the icon and additional artwork as discussed in #31.

[AppVeyorBot]

✅ Build Open-Shell-Menu 4.4.181-dalrueyv completed (commit 41ef9768e2 by @bonzibudd)

[ge0rdi]

Looks good to me.

Just the rounded corner on install screen looks a bit odd (well, I'm not designer):

Win10/11 doesn't seem to use much rounded corners.

[ge0rdi]

One technical note.

Commits Improve setup banner icon and Fix web.ico size are basically fixups of earlier New icons and installer artwork (they just fix things introduced in that original commit).
It will be nice to squash them into original commit in the end.

You can do that easily using git rebase -i origin/master (you can search for git interactive rebase if you are not familiar with it).

[bonzibudd]

I see what you mean with the rounded corners, I will adjust that. I will combine the fix commits as well.

[AppVeyorBot]

✅ Build Open-Shell-Menu 4.4.182-yvmtbmhb completed (commit b528287d11 by @bonzibudd)

[AppVeyorBot]

✅ Build Open-Shell-Menu 4.4.182-cnhcbagb completed (commit 977cd46672 by @ge0rdi)

[bonzibudd]

@ge0rdi I made the changes, but I don't think I should have updated from open-shell-master as they are showing as new commits now. Let me know if I need to change anything from my end.

[ge0rdi]

Hmm, you should sync your master with Open-Shell repo.

First, make sure you have upstream set up, using this guide:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/configuring-a-remote-repository-for-a-fork

Then you should do:
git fetch upstream
git rebase upstream/master

This should end up with just your 2 commits on your master.
Then use git push -f to push that to your repo.

[ge0rdi]

It looks good now.

But AppVeyor is ignoring those changes because:
Commit "e310e60a" of branch "master" skipped as commit files did not match "only_commits.files"

I think it's because the last commit on your branch modifies just readme.md and we are not triggering builds on such changes.

Try to swap those commits (using git rebase -i origin/master).
So that the last commit on branch will change files in Src folder.

[bonzibudd]

Ok, I think it's fixed now. I'll do some spot-checking, but I think it's good to go.

[AppVeyorBot]

✅ Build Open-Shell-Menu 4.4.182-iyypahgu completed (commit 710ba0c21a by @bonzibudd)

[bonzibudd]

Update: I found a possible issue with the installer art.

@ge0rdi I'd like to wait on pushing this for the moment.

[AppVeyorBot]

✅ Build Open-Shell-Menu 4.4.182-enmdumhn completed (commit 2a47c51c66 by @bonzibudd)

[bonzibudd]

@ge0rdi

Alright, everything looks fine now. I had made a silly mistake in the resolution of Dialog2.jpg but it should be correct now.

[ge0rdi]

Looks good to me 👍

[bonzibudd]

@ge0rdi this is off-topic, but I am planning on making a couple changes to Readme. Is it possible to make one PR for both readme and gh-pages, or will they need to be separate?

[ge0rdi]

Nope.
They are on different branches so you need two PRs.
It should be possible to do edits via web interface and it will automatically create new branch and PR from it.