Updates to Help

[bonzibudd]

• New help style
• Grammar fixes/slight reformatting
• Windows 8 -> 8+
• Links now go to Github or Classic shell mirror
• Updated Readme and EULA style to match

Fixes #524, fixes #880, and fixes #1173

[AppVeyorBot]

✅ Build Open-Shell-Menu 4.4.184-fxahbnsq completed (commit fef10ab9ed by @bonzibudd)

[AppVeyorBot]

✅ Build Open-Shell-Menu 4.4.184-nrcmiulh completed (commit a56bc25507 by @bonzibudd)

[ge0rdi]

I think files in Localization folder (in repo root) are not used anywhere (at least I can find any references to them).
Only files in Src/Localization seem to be used (though maybe it would be more logical to have localizations outside of source folder).

You can eventually remove them (in separate commit) to see if build and everything else goes well.
Or I can do that later if you don't want to mess with it.

[ge0rdi]

You can also rename Menu.html to StartMenu.html to fix the Can't reach this page error (see #1241 (comment)).

Though, please do that in separate commit. And don't forget to fix also references to that file in Src/Localization files.

[ge0rdi]

Open-Shell Menu looks weird here (other components don't have Open-Shell in name).
I'd suggest to change it to Start menu.

[ge0rdi]

Or maybe Classic Start Menu (as other components have Classic too).

[bonzibudd]

I agree that it looks weird, but I personally think it makes more sense to keep it consistent with the product name (as shown as the titles of the other pages, etc.) Maybe it could be a future renaming effort?

[ge0rdi]

Oki, lets keep it as it is for now.

[bonzibudd]

I will look at renaming the Menu.html component. Do you know of the other references off-hand?

You can eventually remove them (in separate commit) to see if build and everything else goes well.

So I can remove the entire localization folder without issue?

[ge0rdi]

Do you know of the other references off-hand?

I have found it in Main.html, OpenShell.hhp, OpenShellTOC.hhc (all languages).
So better just search for Menu.html in Src/Localization and replace all the ocurrences.

So I can remove the entire localization folder without issue?

I believe so. Because I don't see any references to that folder.
You should do it in separate commit so that we can easily revert/remove it if it turns out that the folder is required for something.

[AppVeyorBot]

❌ Build Open-Shell-Menu 4.4.184-vvqkcucj failed (commit c1b6718929 by @bonzibudd)

[AppVeyorBot]

❌ Build Open-Shell-Menu 4.4.184-ttokrpro failed (commit 04e79ec173 by @bonzibudd)

[ge0rdi]

Hmm, not sure what's the issue with help compilation :(
You can remove > null from the hhc line in BuildInstaller.bat.
Hopefully this will show some details.

[AppVeyorBot]

❌ Build Open-Shell-Menu 4.4.184-glysmhpk failed (commit 8996e98f7e by @bonzibudd)

[bonzibudd]

I think I missed some references to StartMenu.html. I'll try to fix.

[bonzibudd]

Ok, seems like it may be fixed now. Would you like me to revert the BuildInstaller change?

Edit: I also still need to attach one of the related issues.

[AppVeyorBot]

✅ Build Open-Shell-Menu 4.4.184-jdrboooy completed (commit 1a9af8562b by @bonzibudd)

[bonzibudd]

Updated the description to include #880 and #1173.

[AppVeyorBot]

✅ Build Open-Shell-Menu 4.4.184-ylcsunhu completed (commit 7509597f45 by @bonzibudd)

[ge0rdi]

Ok, seems like it may be fixed now.

Perfect. And the help now works nicely 👍

Would you like me to revert the BuildInstaller change?

Yes, please.
I'd modify scripts later to store the hhc output and display it in case of error.

[ge0rdi]

Could you also fix other languages in Rename Menu.html to StartMenu.html commit?
I mean we don't build those localizations right now, but we may start to do that and it would be nice to have help fixed for them as well.

And for the Remove unnecessary Localization folder commit, please add explanation to commit message that the folder is redundant and is not used for anything (Src/Localization is used instead).

So that we will know why it was removed in the future.

[AppVeyorBot]

✅ Build Open-Shell-Menu 4.4.184-kfcysoap completed (commit 4f255d331b by @bonzibudd)

[AppVeyorBot]

✅ Build Open-Shell-Menu 4.4.184-ggwendrp completed (commit a8f031cc26 by @bonzibudd)

[ge0rdi]

Looks really great.
Thank you so much.

[ge0rdi]

@bonzibudd
I've noticed that screenshots in help file refer to old Classic-Shell (also to old registry paths).
Maybe you can create new screenshots?

[bonzibudd]

@ge0rdi
I'll try to work on new pictures soon. I also have a couple technical things in mind for the Help panel.

I'll also provide some new images for the Start Menu Style page.