Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PKSim and MoBi version is not shown in report #124

Closed
msevestre opened this issue Dec 5, 2017 · 2 comments
Closed

PKSim and MoBi version is not shown in report #124

msevestre opened this issue Dec 5, 2017 · 2 comments
Assignees
@msevestre
Labels
type: bug

Comments

@msevestre
Copy link
Member

This is due to the method GetVesion from FileHelper that should return FileVersion instead of ProductVersion
@msevestre
Copy link
Member Author

see https://github.com/Open-Systems-Pharmacology/OSPSuite.Utility/blob/e01201c77b98b1ec9edb469169ee6dfdffbb1141/src/OSPSuite.Utility/FileHelper.cs#L173

@msevestre
Copy link
Member Author

actually this method should check if one is empty and return the one if yes
The reason for that problem is probably the inclusion of an EAP flag in the release version

@msevestre msevestre self-assigned this Feb 19, 2018
msevestre added a commit to msevestre/OSPSuite.InstallationValidator that referenced this issue Feb 19, 2018
@msevestre
Fixes Open-Systems-Pharmacology#124 version not shown in report
93b22a2
Yuri05 pushed a commit that referenced this issue Feb 20, 2018
@msevestre @Yuri05
Fixes #124 version not shown in report (#126)
5966f75 
* Bump to version 7.2.2

* Fixes #124 version not shown in report
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msevestre msevestre

Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@msevestre