Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1123 markdown export #1126

Merged
merged 3 commits into from Mar 12, 2019
Merged

1123 markdown export #1126

merged 3 commits into from Mar 12, 2019

Conversation

msevestre
Copy link
Member

No description provided.

Copy link
Member Author

@msevestre msevestre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yuri05 Just the infrastructure for now. I'd like you to merge it asap so that I don't have too many merge conflict with the observer stuff that I am starting

@@ -251,6 +256,19 @@ private static void registerReportBuilders(IContainer container)
container.Register<IReportBuilderRepository, ReportBuilderRepository>(LifeStyle.Singleton);
}


private static void registerMarkdownBuilders(IContainer container)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar to our tex builder, we need to implement markdown builder. It should be much simple and I believe could potentially replace Tex in the future

_markdownBuilderRepository = markdownBuilderRepository;
}

public override void Report(Compound compound, MarkdownTracker tracker)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example of (too simple until specified) markdown export for compound

@msevestre msevestre requested a review from Yuri05 March 7, 2019 15:39
@Yuri05 Yuri05 merged commit ee34ac4 into develop Mar 12, 2019
@Yuri05 Yuri05 deleted the 1123-markdown-export branch April 6, 2019 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants