Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #199 Fixes #154 use log ticks and log labels #201

Merged
merged 3 commits into from
Nov 23, 2021

Conversation

pchelle
Copy link
Collaborator

@pchelle pchelle commented Nov 22, 2021

No description provided.

#' Scaling$date
Scaling <- enum(c(
"lin",
"log",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to distinguish between log and log10 scaling here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is possible but not sure if we should: in the config plan, Scaling is log for log10...
I could set up a "ln" that would make the difference clearer in the Scaling enum ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep makes sense. Make sure to comment what those enum are about

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and update the overall comment #' Scaling$date :)

Axis configurations now include 3 new public methods:
* ggplotScale that provides the actual ggplot scale name
* prettyTicks that will get user defined or tlf default ticks
* prettyTickLabels that will get user defined or tlf default ticklabels
@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2021

Codecov Report

Merging #201 (5677189) into develop (4384bc5) will increase coverage by 0.09%.
The diff coverage is 55.31%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #201      +/-   ##
===========================================
+ Coverage    47.72%   47.81%   +0.09%     
===========================================
  Files           55       55              
  Lines         2590     2633      +43     
===========================================
+ Hits          1236     1259      +23     
- Misses        1354     1374      +20     
Impacted Files Coverage Δ
R/tlf-env.R 0.00% <0.00%> (ø)
R/utilities-axis.R 66.66% <0.00%> (-26.67%) ⬇️
R/plotconfiguration-axis.R 83.76% <78.78%> (-1.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4384bc5...5677189. Read the comment docs.

@msevestre msevestre merged commit 46cee6a into Open-Systems-Pharmacology:develop Nov 23, 2021
@pchelle pchelle deleted the 199-logticks branch February 15, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants