Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Rise of Nations Extended Edition #52

Merged
merged 2 commits into from
May 20, 2024
Merged

Update Rise of Nations Extended Edition #52

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a2c33a
Update Rise of Nations: Extended Edition
LukeShortCloud Apr 2, 2024
fde05b4
Update Rise of Nations: Extended Edition
LukeShortCloud May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions gamefixes-steam/287450.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,17 +13,14 @@ def main():
# Install crypt32 (not required for Proton 3.16-3 and up)
util.protontricks('crypt32')

# Install directmusic, set overrides
# Install DirectMusic
util.protontricks('directmusic')
util.winedll_override('dmime', 'n')
util.winedll_override('dmsynth', 'n')
util.winedll_override('dmusic', 'n')
util.winedll_override('dsound', 'n')
util.winedll_override('dswave ', 'n')
util.winedll_override('l3codecx', 'n')

# Set sound to alsa
util.protontricks('sound=alsa')

# Install DirectPlay for reliable multiplayer connections
util.protontricks('directplay')

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe lines 30-37 may be redundant here as specifying the directplay verb already applies the native overrides for those files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. I was confused because the DirectMusic workaround did the same thing. I already checked the winetricks source code and all of the overrides for both DirectMusic and DirectPlay are handled. I will go back and refactor both of those.

# Disable launcher
util.replace_command('patriots.exe', 'riseofnations.exe')