[BUG] [pistache] models don't compile due to calling validate() with no parameters not returning bool

[alanb-sony]

This PR introduced a change to call if (!m_{{name}}.validate()) { but the no-argument validate function throws on errors and returns void, this causes a compiler error:

error: could not convert '((const org::openapitools::Model1*)this)->org::openapitools::Model1::m_Parameters.org::openapitools::Model2::validate()' from 'void' to 'bool'
   47 |     if (!m_Parameters.validate()) {
      |          ~~~~~~~~~~~~~~~~~~~~~^~
      |                               |
      |                               void
openapi/model/Model1.cpp:47:32: error: in argument to unary !
   47 |     if (!m_Parameters.validate()) {
      |                                ^

Found in OpenAPI 7.0.1 with the following command:

npx @openapitools/openapi-generator-cli generate -i api.yml -g cpp-pistache-server -o out

[wing328]

thanks for reporting the issue

cc @@ventsyv (the author of the PR)

[sofiane06]

Hi,

i had the same issue, any news for this please?

error: could not convert ‘((const org::openapitools::server::model::AfEventNotification*)this)->org::openapitools::server::model::AfEventNotification::m_Event.org::openapitools::server::model::AfEvent::validate()’ from ‘void’ to ‘bool’
   48 |     if (!m_Event.validate()) {
      |          ~~~~~~~~~~~~~~~~^~
      |                          |
      |                          void
/home/sofiane/my-workspace/pcf/out1/model/AfEventNotification.cpp:48:27: error: in argument to unary !
   48 |     if (!m_Event.validate()) {
      |                           ^
make[2]: *** [CMakeFiles/api-server.dir/build.make:328: CMakeFiles/api-server.dir/model/AfEventNotification.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:140: CMakeFiles/api-server.dir/all] Error 2
make: *** [Makefile:91: all] Error 2