Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++][Pistache] Compile error when nesting component/schema reference objects (#16711) #18586

Merged

Conversation

keyjh2
Copy link
Contributor

@keyjh2 keyjh2 commented May 7, 2024

When components/schema/ reference other objects, validate() was getting called on the referenced objects with no arguments. The return value was void, but checked as if it was a boolean value.

  • Added message arguments to fixed compiler error in model-source.mustache.
  • Added integration test for this issue (bin/configs/cpp-pistache-server-cpp-pistache-nested-schema-refs.yaml).
  • Added new schema for integration test (modules/openapi-generator/src/test/resources/3_0/nested-schema-refs.yaml).
  • Added generated code from integration test (samples/server/petstore/cpp-pistache-nested-schema-refs/)
  • Removed unused model source files from previous integration test (samples/server/petstore/cpp-pistache/model).
  • Removed pistache install script. Pistache was already getting built as a dependency by CMake.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. - @ravinikam @stkrwork @etherealjoy @MartinDelille @muttleyxd

…6711)

When components/schema/<object> reference other objects, validate() was
getting called on the referenced objects with no arguments. The return
value was void, but checked as if it was a boolean value.
@wing328 wing328 added this to the 7.6.0 milestone May 7, 2024
@wing328
Copy link
Member

wing328 commented May 7, 2024

@wing328
Copy link
Member

wing328 commented May 7, 2024

thanks for the PR. let's give it a try

@wing328 wing328 merged commit be94c22 into OpenAPITools:master May 7, 2024
13 of 14 checks passed
@keyjh2 keyjh2 deleted the issue_16711_compile_error_validate branch May 7, 2024 14:43
renatomameli pushed a commit to renatomameli/openapi-generator that referenced this pull request May 17, 2024
…6711) (OpenAPITools#18586)

When components/schema/<object> reference other objects, validate() was
getting called on the referenced objects with no arguments. The return
value was void, but checked as if it was a boolean value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants