Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [Ruby] The generated Ruby client is using deprecated type Fixnum #2475

Closed
6 tasks done
autopp opened this issue Mar 22, 2019 · 1 comment
Closed
6 tasks done

Comments

@autopp
Copy link
Contributor

autopp commented Mar 22, 2019

Bug Report Checklist

  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • What's the version of OpenAPI Generator used?
  • Have you search for related issues/PRs?
  • What's the actual output vs expected output?
  • [Optional] Bounty to sponsor the fix (example)
Description

The generated Ruby client is using Fixnum in YARD tag. Fixnum is deprecated in Ruby 2.4.0 and later (and integrated into Integer).

openapi-generator version
$ java -jar modules/openapi-generator-cli/target/openapi-generator-cli.jar version
4.0.0-SNAPSHOT

$ git log --oneline -n 1
ee75366051 (HEAD -> master, origin/master, origin/HEAD) Added proxy headers option for urllib3 (#2467)
OpenAPI declaration file content or url

N/A

Command line used for generation

N/A

Steps to reproduce

See:

Related issues/PRs

N/A

Suggest a fix

Use Integer instead of Fixnum. Integer is also available in versions below 2.4.0.

@auto-labeler
Copy link

auto-labeler bot commented Mar 22, 2019

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

autopp added a commit to autopp/openapi-generator that referenced this issue Mar 22, 2019
autopp added a commit to autopp/openapi-generator that referenced this issue Mar 22, 2019
wing328 pushed a commit that referenced this issue Mar 23, 2019
* use Integer instead of Fixnum in Ruby client (#2475)

* update samples (#2475)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant