[BUG][JAVA][Spring] Config options for Pageable & ApiIgnore

[morphlne]

Bug Report Checklist

• Have you provided a full/minimal spec to reproduce the issue?
• Have you validated the input using an OpenAPI validator (example)?
• Have you tested with the latest master to confirm the issue still exists?
• Have you searched for related issues/PRs?
• What's the actual output vs expected output?

Description

Trying to generate pure interfaces using next config:

<generateSupportingFiles>false</generateSupportingFiles>
<configOptions>
    <openApiNullable>false</openApiNullable>
    <java8>false</java8>
    <interfaceOnly>true</interfaceOnly>
    <hideGenerationTimestamp>true</hideGenerationTimestamp>
</configOptions>

Following lines are added to generated api file:

import org.springframework.data.domain.Pageable;
import springfox.documentation.annotations.ApiIgnore;

and produced compilation error due those classes needed additional dependencies (spring-data-commons&springfox-core)

Didn't manage to find any option to disable those imports (like openApiNullable for disabling org.openapitools.jackson.nullable.JsonNullable)

openapi-generator version

5.0.0

OpenAPI declaration file content or url

Sample project for quick reproducing https://github.com/morphlne/openapi-generator-demo

Steps to reproduce

Clone https://github.com/morphlne/openapi-generator-demo.git
run mvn compile

Related issues/PRs

Both imports added in mustache files in PR: #5022

Suggest a fix

Add support for next config options:

<usePageable>false</usePageable>
<useApiIgnore>false</useApiIgnore>

[feliperuiz]

I believe #8192 also relates to this. It seems to have been introduced by #5022, which added the imports for @ApiIgnore and Pageable without checking they are indeed required to be present.

There seems to exist a computed flag/setting for the use of @ApiIgnore—springfox as a whole, more accurately—but it gets imported without checking it.

I was actually facing the same issue and was planning on coming up with a patch to only add those imports when they're needed, but I couldn't find my way around the test suite—which test methods/resources would need to be updated, or even how to properly run the tests in the first place =/

[borsch]

@feliperuiz there is no need to run tests. after you fix templates you simply has to re-generate all related samples via ./bin/generate-samples.sh to generate all or ./bin/generate-samples.sh bin/configs/CONFIG.yaml to generate specific (ex: ./bin/generate-samples.sh bin/configs/java-vertex.yaml

[morphlne]

Fixed locally by adding new config options & changing mustache template. Will prepare PR for this fix

[MatCyg]

Is there any workaround available already? (beside adding unnecessary imports to you project)

[morphlne]

@MatCyg As quick solution you can use 5.0.0-beta2 and any earlier version

[pierrefevrier]

Same problem with version 5.0.1

[bruteforce]

Any workaround?

[morphlne]

@bruteforce partially resolved in #8915, 5.1.0 release
My proposed solution (#8421) still waiting for review

[samjingwen]

Is this issue fixed in the latest release?

[flabbamann]

Seems to be fixed in 5.3.0

[morphlne]

Resolved in 5.3.0