-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JAVA] [Spring] Conditionally importing spring pageable #8915
[JAVA] [Spring] Conditionally importing spring pageable #8915
Conversation
Can you try pulling latest master to your branch? Failures don't look to be related, might have been fixed. |
@agilob Have updated the branch with master but still still circle-ci seems to be failing. |
|
@agilob Thanks. Build passes now. |
@wing328 pls merge before 5.1 |
@ajithalbus thanks for the PR @agilob thanks for the review. |
@ajithalbus thanks for the PR, which has been included in the v5.1.0 release: https://twitter.com/oas_generator/status/1373636654024380423 |
TL;DR - Making import of "org.springframework.data.domain.Pageable" conditional on "vendorExtensions.x-spring-paginated".
Spring pageable is from spring-data package and is not really required in (compile)classpath unless enabled through the vendor extension "x-spring-paginated". With this patch, simple spring projects with no actual dependency to spring-data, does not have to keep spring-data in classpath.
Please review @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01) @wing328
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
,5.1.x
,6.0.x