Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JAVA] [Spring] Conditionally importing spring pageable #8915

Merged
merged 4 commits into from
Mar 17, 2021

Conversation

ajithalbus
Copy link
Contributor

TL;DR - Making import of "org.springframework.data.domain.Pageable" conditional on "vendorExtensions.x-spring-paginated".

Spring pageable is from spring-data package and is not really required in (compile)classpath unless enabled through the vendor extension "x-spring-paginated". With this patch, simple spring projects with no actual dependency to spring-data, does not have to keep spring-data in classpath.

Please review @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01) @wing328

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@ajithalbus ajithalbus changed the title [JAVA] [Spring] Changing spring pageable import conditional [JAVA] [Spring] Conditionally importing spring pageable Mar 7, 2021
@agilob
Copy link
Contributor

agilob commented Mar 10, 2021

Can you try pulling latest master to your branch? Failures don't look to be related, might have been fixed.

@ajithalbus
Copy link
Contributor Author

@agilob Have updated the branch with master but still still circle-ci seems to be failing.

@agilob
Copy link
Contributor

agilob commented Mar 11, 2021

 Run the following to build the project and update samples:

./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh

@ajithalbus
Copy link
Contributor Author

@agilob Thanks. Build passes now.

@agilob
Copy link
Contributor

agilob commented Mar 17, 2021

@wing328 pls merge before 5.1

@wing328
Copy link
Member

wing328 commented Mar 17, 2021

@ajithalbus thanks for the PR

@agilob thanks for the review.

@wing328 wing328 merged commit 9ea852d into OpenAPITools:master Mar 17, 2021
@wing328 wing328 added this to the 5.1.0 milestone Mar 17, 2021
@ajithalbus ajithalbus deleted the spring-pageable-import branch March 17, 2021 18:47
@wing328
Copy link
Member

wing328 commented Mar 22, 2021

@ajithalbus thanks for the PR, which has been included in the v5.1.0 release: https://twitter.com/oas_generator/status/1373636654024380423

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants