Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP] New client generator php-dt #10041

Merged
merged 6 commits into from Aug 15, 2021
Merged

[PHP] New client generator php-dt #10041

merged 6 commits into from Aug 15, 2021

Conversation

Articus
Copy link
Contributor

@Articus Articus commented Jul 26, 2021

Added php-dt - new client generator for PHP language. Generated client is lightweight and extensible, relies on Data Transfer for handling request/response content and complies with PSR-7, PSR-11, PSR-17 and PSR-18.

This PR also makes php-mezzio-ph description in README.md up-to-date - I hope that is ok to make this micro update together with adding information about new generator.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.3.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @jebentier @dkarlovi @mandrean @jfastnacht @ackintosh @ybelenko @renepardon

@Articus
Copy link
Contributor Author

Articus commented Jul 29, 2021

I am at loss what to do with failing Maven plugin and Gradle plugin tests :[ PR does not touch them, error message from CI is a bit confusing and worst of all - build of poms for both plugins fails in my local development environment even if I take code from master. Could anyone please help to investigate these failed CI jobs?

@wing328 wing328 added this to the 5.2.1 milestone Aug 3, 2021
@wing328
Copy link
Member

wing328 commented Aug 3, 2021

Please ignore those maven, gradle plugin issues as that happens with the master branch as well.

@wing328
Copy link
Member

wing328 commented Aug 15, 2021

@Articus thanks for the new generator. Looks good to me to include in the upcoming release to get feedback from our users.

@wing328 wing328 merged commit 2210c9f into OpenAPITools:master Aug 15, 2021
@prochac
Copy link

prochac commented Jan 18, 2023

@wing328 is there any new generator policy, or just more == better? Do we need a generator in upstream that's build on top of library with 7 stars?
https://github.com/Articus/DataTransfer
@Articus no hard feelings, I just think that this splits PHP ecosystem and makes confusion.

@Articus
Copy link
Contributor Author

Articus commented Jan 18, 2023

@prochac , it seems you missed the main part - compliance with PSR-7, PSR-11, PSR-17 and PSR-18. "No hard feelings", but if these PHP standards mean nothing to you, maybe count stars for corresponding repositories - https://github.com/php-fig/http-message , https://github.com/php-fig/container , https://github.com/php-fig/http-factory , https://github.com/php-fig/http-client ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants