New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated methods in default codegen #1031

Merged
merged 2 commits into from Dec 6, 2018

Conversation

Projects
None yet
3 participants
@wing328
Member

wing328 commented Sep 13, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.3.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

A follow-up PR to #859.

@wing328 wing328 referenced this pull request Sep 13, 2018

Merged

Refactor StringUtils functions #859

4 of 4 tasks complete

@wing328 wing328 added this to the 3.3.0 milestone Sep 13, 2018

@ackintosh

This comment has been minimized.

Member

ackintosh commented Sep 13, 2018

https://app.shippable.com/github/OpenAPITools/openapi-generator/runs/2928/1/console

[ERROR] COMPILATION ERROR :
[ERROR] /root/src/github.com/OpenAPITools/openapi-generator/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/DartJaguarClientCodegen.java:[147,38] cannot find symbol
symbol: method underscore(java.lang.String)
location: class org.openapitools.codegen.languages.DartJaguarClientCodegen

Oh, shippable has failed. 👀

@jmini

This comment has been minimized.

Member

jmini commented Sep 13, 2018

From a Java-API point of view (for people having their own generator) this is a breaking change without fallback.

I suggest to target 4.0 for a change like this one.

cc: @jimschubert

@wing328

This comment has been minimized.

Member

wing328 commented Sep 13, 2018

@jmini agreed with you. The user using a customized generator will need to do something in order to make it work after upgrading to 3.3.0 if we decide to merge the PR into master.

I don't mind targeting this change for 4.0.x instead.

@wing328

This comment has been minimized.

Member

wing328 commented Sep 13, 2018

@ackintosh I think that's because shippable merged origin/master into this branch. I'll merge master or 4.0.x into this branch later after we have a decision on which branch to target.

@wing328 wing328 removed this from the 3.3.0 milestone Sep 13, 2018

@wing328 wing328 changed the base branch from master to 4.0.x Nov 5, 2018

@wing328 wing328 added this to the 4.0.0 milestone Nov 5, 2018

@wing328 wing328 changed the base branch from 4.0.x to master Dec 6, 2018

@wing328 wing328 merged commit 314b4cc into master Dec 6, 2018

6 checks passed

Shippable Run 4536 status is SUCCESS.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@wing328 wing328 deleted the deprecate_string_function branch Dec 6, 2018

wing328 added a commit that referenced this pull request Dec 6, 2018

Better OpenAPI spec v3 support: allOf, anyOf, oneOf (#1360)
* add oneOf support to Ruby

* add anyOf support to ruby client

* add discriminator support to ruby client

* fix typo

* update samples, fix NPE

* better format in ruby generator

* fix test cases, disable mapping test

* fix update script, update samples

* add test, fix mapping

* update exit code

* reenabled discriminator test

* remove duplicated properties

* add test for duplicated properties

* update samples, add new spec

* fix ruby test cases

* fix hasMore after removing duplicates

* refactor method, comment out haskell client test

* fix hasMore and update samples

* fix parent detection

* fix discriminator check

* [haskell-http-client] need to use {{vars}}{{required}} instead of {{requiredVars}}

* remove deprecated methods in default codegen (#1031)

* regenerate samples

* remove commented code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment