Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[swift5][client] Fix module and class with same name #10387

Merged
merged 2 commits into from Sep 14, 2021

Conversation

4brunu
Copy link
Contributor

@4brunu 4brunu commented Sep 13, 2021

It fixes #9953

With #9624 we changed a class from #projectName#API to #projectName#.

But it seems that the Swift compiler had a bug related to projects that have a class with the same name of the module.

More details on this #9953 and https://bugs.swift.org/browse/SR-898.

This PR reverts the change from #projectName#API to #projectName#, but keeps the reference to a warning to help with the transition.
Once the transition is made, this warning can be removed with the new introduced flag removeMigrationProjectNameClass.

@aymanbagabas do you have other suggestions to fix this issue?

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11)

@aymanbagabas
Copy link
Contributor

@4brunu no, I think this workaround is the best way to solve this issue at least until the bug is fixed.

@wing328 wing328 added this to the 5.3.0 milestone Sep 14, 2021
@wing328 wing328 merged commit 27727ac into OpenAPITools:master Sep 14, 2021
@wing328 wing328 changed the title [swift5][client] Fix issue 9953 [swift5][client] Fix module and class with same name Oct 23, 2021
@4brunu 4brunu deleted the fix/9953 branch December 14, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][swift5] module and class with same name
3 participants