-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift5 namespace changes #9624
Swift5 namespace changes #9624
Conversation
Instead of {{projectName}}API. This removes some unnecessary naming complexity.
When swiftUseApiNamespace is set, API classes get defined under the projectName namespace. This does the same for models and the Configuration class. Plus adding a deprecation warning when using the un-namespaced variants.
Fixes: 0f5e7d1 ("Swift5 models improvements (OpenAPITools#9205)")
modules/openapi-generator/src/main/resources/swift5/modelObject.mustache
Show resolved
Hide resolved
@aymanbagabas Since this PR is big because this changes modify a lot of files in the sample projects, I opened aymanbagabas#16 to reduce the model changes, and make it easier to review this PR. |
@aymanbagabas overall the PR looks good, I just would like to understand better the changes in the method |
Since we're using |
Thanks, looks good to me 👍 |
@aymanbagabas can you please resolve the merge conflicts when you've time? |
Thanks for fixing the merge conflicts 👍 |
Based on this discussion #9583 (review)
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
,5.1.x
,6.0.x