Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[csharp-netcore] allow to specify content-type for files #10473

Merged

Conversation

llRandom
Copy link
Contributor

@llRandom llRandom commented Sep 25, 2021

The changes allow to specify content-type for files sent using csharp-netcore client. If content-type is not set explicitly it will be set to application/octet-stream as it is currently set fo all files.

To close #10472

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 added this to the 5.3.0 milestone Sep 26, 2021
@wing328 wing328 changed the title #10472 csharp-netcore client - allow to specify content-type for files [csharp-netcore] allow to specify content-type for files Sep 26, 2021
@wing328
Copy link
Member

wing328 commented Sep 26, 2021

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@llRandom llRandom force-pushed the 10472-csharp-netcore-file-content-type branch from a3e41e2 to a1efb3b Compare September 26, 2021 13:37
@llRandom
Copy link
Contributor Author

I've updated the author. Is it fine now?

@wing328
Copy link
Member

wing328 commented Sep 26, 2021

Looks good now. Windows tests passed via https://ci.appveyor.com/project/WilliamCheng/openapi-generator/builds/40911871

@wing328 wing328 merged commit 60b29e1 into OpenAPITools:master Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ] [csharp-netcore] Allow to specify content-type when sending a file
2 participants