Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove eclipse formatter plugin #10547

Merged
merged 1 commit into from
Oct 9, 2021

Conversation

agilob
Copy link
Contributor

@agilob agilob commented Oct 6, 2021

I doesn't seem to be used as formatter:format is not used anywhere in this repo

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

<groupId>net.revelc.code</groupId>
<artifactId>formatter-maven-plugin</artifactId>
<!-- Uncomment this to format before checkstyle -->
<!-- <executions>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not part of compile stage, and not triggered by name

@agilob
Copy link
Contributor Author

agilob commented Oct 6, 2021

@wing328 @jimschubert

@agilob
Copy link
Contributor Author

agilob commented Oct 6, 2021

when triggered manually on master produced 555 changed files, 100% not used

@wing328
Copy link
Member

wing328 commented Oct 9, 2021

A little big more background on this: in short, we didn't activate the plugin since using this change will result in a lot of changes to the master and lots of PRs (pending review) will need to be rebased or manually resolved the conflicts, which is not something we want.

@wing328 wing328 added Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. Feature: Generator labels Oct 9, 2021
@wing328 wing328 added this to the 5.3.0 milestone Oct 9, 2021
@wing328 wing328 merged commit cd9bd96 into OpenAPITools:master Oct 9, 2021
@agilob agilob deleted the remove-formatter-maven branch October 9, 2021 09:29
@agilob
Copy link
Contributor Author

agilob commented Oct 9, 2021

Yes, I agree, if anything this plugin should be triggered by git commit hook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. Feature: Generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants