[Python] Commenting supportsInheritance is enabling the model properties inhe… #1099
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@wing328
CC'ing technical committee: @taxpon @frol @mbohlool @cbornet @kenjones-cisco to review the pull request if your PR is targeting python programming language.
Description of the PR
It is kind of counter intuitive, but setting
supportsInheritance = true
is failing to get the properties from the parent when a child model inherits. Didn't dive deep in to the actual base class for the code generation, but commenting out the line fromPythonClientCodegen.java
fixed the issue.This solves the reported issues
There could be multiple reasons since I didn't go to the root cause
AbstractPyCodegen.java
, which might/might not tackle the issuesupportsInheritence = true
in their generation code. Just to quote a fewAbstractJavaCodegen
(@bbdouglas @JFCote @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger )JavascriptClientCodegen
(@CodeNinjai @frol @cliffano)CSharpClientCodegen
/AbstractCSharpCodegen.java
(@mandrean @jimschubert)AbstractKotlinCodegen
(@jimschubert @dr4ke616)