Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][csharp-netcore] Fix Multi Files for the same FormField #11259

Merged
merged 2 commits into from
Jan 11, 2022

Conversation

joaocmendes
Copy link
Contributor

@joaocmendes joaocmendes commented Jan 8, 2022

Fix issue #11132

FileParameters at Request Options is a Dictionary so we weren't able to send more than one file with the same key.
Refactor FileParamerts to Multimap to enable sending more than one file with the same key.

I did the development only for csharp-netcore but it has no impacts and can be made to the others generators.

If you find it useful say it at the review.
@mandrean
@shibayan
@Blackclaws
@lucamazzanti

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

…Tools#11132)

Make FileParamerts a Multimap to enable sending more than one file with the same key.
@joaocmendes joaocmendes changed the title [BUG][csharp-netcore] Fix Multi Files for the some FormField (#11132) [BUG][csharp-netcore] Fix Multi Files for the same FormField (#11132) Jan 8, 2022
@wing328 wing328 added this to the 5.4.0 milestone Jan 9, 2022
@wing328
Copy link
Member

wing328 commented Jan 10, 2022

C# tests (with updates samples passed via https://ci.appveyor.com/project/WilliamCheng/openapi-generator/builds/42144330 )

@joaocmendes
Copy link
Contributor Author

I've done a force push because I follow the instructions to generate the samples and it added a lot of changes for slash replacement. I reset and commit only things related to this issue.
I don't know why the build failed, I tried to look to logs but didn't add much. May we re-run the job?

@wing328
Copy link
Member

wing328 commented Jan 11, 2022

The bitrise CI failure can be ignored.

@wing328 wing328 merged commit b05faef into OpenAPITools:master Jan 11, 2022
@wing328
Copy link
Member

wing328 commented Jan 11, 2022

@joaocmendes thanks for the PR, which has been merged into master.

@wing328 wing328 changed the title [BUG][csharp-netcore] Fix Multi Files for the same FormField (#11132) [BUG][csharp-netcore] Fix Multi Files for the same FormField Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants