Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GO] Fix for Pass by value/Pass by Reference changes which is breaking the go client #11466

Merged
merged 1 commit into from
Feb 13, 2022

Conversation

the-akhil-nair
Copy link
Contributor

The commit aeneasr@0c5e5ae in the PR : #8491 resolves the pointer issue, missed the logic to perform similar operation in case of Unmarshalling of the JSON.

Due to this, there is a mismatch between the data type(This issue is seen for array of object type property) between Dog type and DogWithoutEmbeddedStruct type(Present inside Unmarshalling method).

Applying the same logic mentioned in the above commit in UnmarshalJSON method.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @jirikuncar (2021/01) @ph4r5h4d (2021/04)

There was a difference in logic for Unmarshalling the JSON.
The new logic is re-used here.
@wing328
Copy link
Member

wing328 commented Feb 13, 2022

@the-akhil-nair thanks for the PR, which has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants