New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify updatePetWithForm in Go client #1212

Merged
merged 2 commits into from Oct 11, 2018

Conversation

Projects
None yet
1 participant
@wing328
Member

wing328 commented Oct 10, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

A follow-up PR to #1187

cc @antihax (2017/11) @bvwells (2017/12) @grokify (2018/07) @kemokemo (2018/09)

@wing328 wing328 added this to the 3.3.1 milestone Oct 10, 2018

@wing328

This comment has been minimized.

Show comment
Hide comment
@wing328

wing328 Oct 10, 2018

Member

Before the fix, the build failed (https://circleci.com/gh/OpenAPITools/openapi-generator/2813) which is the expected result.

Member

wing328 commented Oct 10, 2018

Before the fix, the build failed (https://circleci.com/gh/OpenAPITools/openapi-generator/2813) which is the expected result.

@wing328 wing328 merged commit 32c1d9e into master Oct 11, 2018

5 checks passed

Shippable Run 3442 status is SUCCESS.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wing328 wing328 deleted the go_add_test branch Oct 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment