Fix regex generated in Ruby client #1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…recognizing \d correctly in Ruby client.
ggershoni
commented
Nov 6, 2018
| @@ -13,7 +13,7 @@ GEM | |||
| public_suffix (>= 2.0.2, < 4.0) | |||
| autotest (4.4.6) | |||
| ZenTest (>= 4.4.1) | |||
| autotest-fsevent (0.2.13) | |||
| autotest-fsevent (0.2.14) | |||
There was a problem hiding this comment.
updated from 0.2.13 to 0.2.14 because doing a bundle install with 0.2.13 was getting:
Darwin 18 is not (yet) supported (RuntimeError)
upgrading to 0.2.14 fixed issue.
|
@ggershoni the fix looks good to me and it's perfectly fine to update the dependencies. Thanks for your contribution. |
wing328
changed the title
|
@ggershoni thanks for the PR, which has been included in the v3.3.3 release: https://twitter.com/oas_generator/status/1062929948191510528 |
|
Woohoo! Thanks heaps @wing328 :-) |
This was referenced Nov 18, 2018
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
…in Ruby client. (OpenAPITools#1393) * Added tests and fix for issue OpenAPITools#1392. Param validation with regex not recognizing \d correctly in Ruby client. * Added generated files to pass ./bin/utils/ensure-up-to-date which is run by circleci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see #1392 for details
Note: I needed to update
autotest-fsevent (0.2.13)toautotest-fsevent (0.2.14)inGemfile.lockto make rspec work on macOS.Would love your thoughts/advice @cliffano @zlx.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.4.x,4.0.x. Default:master.Description of the PR
(details of the change, additional tests that have been done, reference to the issue for tracking, etc)
In
AbstractRubyCodegenoverloadedpublic String toRegularExpression(String pattern)fromDefaultCodegen. Am not escaping the pattern (so no extra \ added) since the regex pattern is run inside regex delimiters already.Added tests in both Java and Ruby client code.