Generate a ruby-client sample for OpenAPI 2.0 #1482
Conversation
|
I found that the generated ruby-client for OpenAPI 2.0 has a syntax-error. > Regexp.new(/^(?:[A-Za-z0-9+/]{4})*(?:[A-Za-z0-9+/]{2}==|[A-Za-z0-9+/]{3}=)?$)
Traceback (most recent call last):
1: from /Users/meganemura/.rbenv/versions/2.5.3/bin/irb:11:in `<main>'
SyntaxError ((irb):1: premature end of char-class: /^(?:[A-Za-z0-9+/)
(irb):1: syntax error, unexpected ']', expecting ')'
Regexp.new(/^(?:[A-Za-z0-9+/]{4})*(?:[A-Za-z0-9+/]{2}==|[A...https://github.com/OpenAPITools/openapi-generator/pull/1482/files#diff-cb91f29a2d3eab894268b3e54a7df278R198 See also #1393 |
|
@wing328 Would you please review this? |
$ git mv sample/client/petstore/ruby sample/openapi3/client/petstore/ruby-client
meganemura
force-pushed
the
ruby-samples
branch
from
d30d978
to
f3bcf0c
Compare
|
@meganemura thanks for the fix. I'll review shortly. For the following:
I prefer putting Petstore client samples for OpenAPI v3 spec under |
|
@wing328 This change moves ruby-client v3 from sample/client/petstore to sample/openapi3/client/petstore. |
|
@meganemura PR merged into master. Thanks for the PR. |
* Move output directory for bin/openapi3/ruby-client-petstore.sh $ git mv sample/client/petstore/ruby sample/openapi3/client/petstore/ruby-client * $ bin/ruby-client-petstore.sh * Run bin/ruby-client-petstore.sh in bin/utils/ensure-up-to-date
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.4.x,4.0.x. Default:master.Description of the PR
Move output directory for bin/openapi3/ruby-client-petstore.sh
to
sample/client/petstore/rubyfrom
sample/openapi3/client/petstore/ruby-client.And generate ruby-client for OpenAPI 2.0 by
bin/ruby-client-petstore.shto
sample/client/petstore/ruby.(details of the change, additional tests that have been done, reference to the issue for tracking, etc)