Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpp-qt5] Sanitize Model and API filenames #1411

Merged

Conversation

etherealjoy
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Port #1409 to master

@ravinikam @fvarose @stkrwork @MartinDelille

Copy link
Contributor

@stkrwork stkrwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but your pull request name is missleading should be sanitize model and api file names

@etherealjoy etherealjoy changed the title [cpp-qt5] Sanitize Model Import [cpp-qt5] Sanitize Model and API filenames Nov 10, 2018
@etherealjoy
Copy link
Contributor Author

@stkrwork
I updated the title.

@etherealjoy etherealjoy merged commit fd46b4e into OpenAPITools:master Nov 10, 2018
@wing328
Copy link
Member

wing328 commented Nov 15, 2018

@etherealjoy thanks for the PR, which has been included in the v3.3.3 release: https://twitter.com/oas_generator/status/1062929948191510528

@etherealjoy etherealjoy deleted the cpp-qt5-sanitize-modelimport branch November 20, 2018 13:30
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants