[typescript-axios] Upgrade to axios@^1

[segevfiner]

Fixes #14517, we need to consider if this is a breaking change or not in terms of OpenAPI generator versioning.

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package 
  ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04)

[macjohnny]

It looks like this is a breaking change, so can you change the target branch to 7.0.0? Or we could introduce an option similar to the version in the typescript-angular generator

[segevfiner]

It looks like this is a breaking change, so can you change the target branch to 7.0.0? Or we could introduce an option similar to the version in the typescript-angular generator

Yeah. It is. Do you prefer an option, which you can then change to be default in v7, or to do this for v7 only?

[macjohnny]

If you are fine waiting for 7.0.0 to be released, lets do it without introducing an option, see https://github.com/OpenAPITools/openapi-generator/milestones

[segevfiner]

@macjohnny Rebased to 7.0.x

[macjohnny]

LGTM
thanks for your contribution!

[macjohnny]

can you have a look at the error

Run `npm audit` for details.

> typescript-axios-test@1.0.0 test
> mocha test/*.ts --require ts-node/register --timeout 10000


TypeError: Unknown file extension ".ts" for /home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/typescript-axios/tests/default/test/PetApi.

in https://app.circleci.com/pipelines/github/OpenAPITools/openapi-generator/21734/workflows/dba99547-9932-4271-a5fd-d3c723b45ddc/jobs/58836?invite=true#step-116-2058

[segevfiner]

Seems like something with package.json & package-lock.json files is still messed up, any idea?

[MajdT51]

Hi :) any update on this PR ? thanks

[macjohnny]

@segevfiner can you please merge the most recent master, resolve the conflicts and fix the tests?

[MajdT51]

update to 1.4.0 if possible 1.4.0

[apptio-mrejdych]

Is it possible to update to 1.6.0. Previous versions contain CSRF vulnerability

[caioquirino]

@segevfiner I don't have access to CircleCI for some reason, but I am happy to help here. Can you try to rebase it again, while I try to be able to check the failed tests please? :)

[segevfiner]

Rebased. It looks like the tests expect axios to get hoisted, but it doesn't get hoisted...

[segevfiner]

Tried modifying the setup there to depend on axios explicitly but without specifying a version to force it to hoist and cleaned up the package.json, fixing a bogus npm install command there that made the tests depend on their run order.

[caioquirino]

Awesome stuff @segevfiner / @macjohnny ! Is there any idea about when it will be generally available please? :) Thanks!