Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE in the C# Nancy generator #1478

Merged
merged 1 commit into from Nov 17, 2018
Merged

Fix NPE in the C# Nancy generator #1478

merged 1 commit into from Nov 17, 2018

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Nov 17, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Fix the following NPE:

[main] WARN  o.o.codegen.utils.ModelUtils - Multiple schemas found, returning only the first one
[main] INFO  o.o.codegen.DefaultGenerator - Model periodicPaymentInitiationMultipartBody (marked as unused due to form parameters) is generated due to skipFormModel=false (default)
[main] INFO  o.o.codegen.DefaultGenerator - Model periodicPaymentInitiation_xml-Part2-standingorderType_json (marked as unused due to form parameters) is generated due to skipFormModel=false (default)
Exception in thread "main" java.lang.NullPointerException
	at org.openapitools.codegen.languages.CSharpNancyFXServerCodegen.postProcessParentModels(CSharpNancyFXServerCodegen.java:288)
	at org.openapitools.codegen.languages.CSharpNancyFXServerCodegen.postProcessAllModels(CSharpNancyFXServerCodegen.java:280)
	at org.openapitools.codegen.DefaultGenerator.generateModels(DefaultGenerator.java:439)
	at org.openapitools.codegen.DefaultGenerator.generate(DefaultGenerator.java:865)
	at org.openapitools.codegen.cmd.Generate.run(Generate.java:349)
	at org.openapitools.codegen.OpenAPIGenerator.main(OpenAPIGenerator.java:62)

cc @mandrean (2017/08) @jimschubert (2017/09)

@jimschubert jimschubert merged commit 941b3ea into master Nov 17, 2018
@jimschubert
Copy link
Member

Thanks!

@jimschubert jimschubert deleted the fix_npe_nancyfx branch November 17, 2018 15:11
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants