Improve error message when the spec is not found #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An error message after merging this PR. 📝 $ java -jar modules/openapi-generator-cli/target/openapi-generator-cli.jar generate -g go -i foo.yaml
[error] The spec file is not found: foo.yaml
[error] Check the path of the OpenAPI spec and try again. |
|
https://circleci.com/gh/OpenAPITools/openapi-generator/3517#tests/containers/2 Probably we need to use https://hub.docker.com/r/openapitools/openapi-petstore/ to resolve the error. It will be done in other PR. |
|
cc @OpenAPITools/generator-core-team |
jimschubert
approved these changes
Nov 27, 2018
jimschubert
approved these changes
Nov 27, 2018
| @@ -246,6 +247,11 @@ public void run() { | |||
| } | |||
|
|
|||
| if (isNotEmpty(spec)) { | |||
| if (!spec.matches("^http(s)?://.*") && !new File(spec).exists()) { | |||
| System.out.println("[error] The spec file is not found: " + spec); | |||
There was a problem hiding this comment.
Do you mean to write an error message to System.out here? This would be surprising to me as a user. Seems like maybe a typo?
There was a problem hiding this comment.
Oops it's typo. 😅
|
@jimschubert Thanks for pointing it out. Fixed the typo. |
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
* Improve error message when spec not found * Add test yaml * Fix invalid yaml file path * Fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.4.x,4.0.x. Default:master.Description of the PR
This PR closes #1449