Added converterFactories property to ApiClient in jvm-retrofit2. #15008
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing
converterFactory
property worked fine, but was not available in certain cases.I think there are these problems.
converterFactory
.converterFactory
can only be added at the very end.In my case, I had to add my custom Converter.Factory first, because JsonParser doesn't handle empty strings and throws an exception. (#14982)
At first, I planned to add a
preConverterFactory
property, but changedconverterFactory
to an array to make it more customizable.For backwards compatibility,
converterFactory
has not been removed from the code, it has been left using the @deprecated annotation.I think this PR of mine will help you meet more requirements.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(6.3.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks)@jimschubert, @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m @wing328