Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added converterFactories property to ApiClient in jvm-retrofit2. #15008

Conversation

dylan-kwon
Copy link
Contributor

The existing converterFactory property worked fine, but was not available in certain cases.

I think there are these problems.

  1. You can add only one converterFactory.
  2. converterFactory can only be added at the very end.

In my case, I had to add my custom Converter.Factory first, because JsonParser doesn't handle empty strings and throws an exception. (#14982)

At first, I planned to add a preConverterFactory property, but changed converterFactory to an array to make it more customizable.

For backwards compatibility, converterFactory has not been removed from the code, it has been left using the @deprecated annotation.

I think this PR of mine will help you meet more requirements.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date.sh
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jimschubert, @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m @wing328

@dylan-kwon
Copy link
Contributor Author

Hi, @4brunu

ci/circleci: node3 — Your tests failed on CircleCI Any idea what could be causing this to fail?

Copy link
Contributor

@4brunu 4brunu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@4brunu
Copy link
Contributor

4brunu commented Mar 22, 2023

CI failure it's not related to this PR.

[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (npm-test) on project TypeScriptBrowserPetstoreClientTests: Command execution failed.: Process exited with an error: 1 (Exit value: 1) -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <args> -rf :TypeScriptBrowserPetstoreClientTests

@4brunu 4brunu merged commit b6d2e0d into OpenAPITools:7.0.x Mar 22, 2023
@wing328 wing328 added this to the 6.5.0 milestone Apr 1, 2023
@wing328 wing328 modified the milestones: 6.5.0, 7.0.0 Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants