Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JAVA][NATIVE] Fix NPE for form values request builder #15036

Merged
merged 1 commit into from Mar 29, 2023

Conversation

RInverid
Copy link
Contributor

Skip null form values, so no empty fields are sent. Before this change, null values were not an option (that would cause an NPE). The best could be an empty string.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608

@RInverid RInverid changed the title Skip null form values for Java native request builder [JAVA][NATIVE] Fix NPE for form values request builder Mar 28, 2023
@RInverid
Copy link
Contributor Author

@wing328 any chance this can be looked at before the 6.5.0 release?

@wing328
Copy link
Member

wing328 commented Mar 29, 2023

LGTM. Thanks for the fix.

@wing328 wing328 merged commit 3633233 into OpenAPITools:master Mar 29, 2023
44 checks passed
@wing328 wing328 added this to the 6.5.0 milestone Mar 29, 2023
@RInverid RInverid deleted the skip_null_form_values branch March 29, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants