Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kotlin-Spring] add Kotlin based Spring Cloud OpenFeign generator #15048

Merged
merged 1 commit into from Apr 24, 2023

Conversation

gr4cza
Copy link
Contributor

@gr4cza gr4cza commented Mar 25, 2023

Add Kotlin based Spring Cloud OpenFeign Client generator. It is based on the already existing JavaSpring spring-cloud library.

e.g. --library spring-cloud via CLI

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date.
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.6.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03)

@gr4cza gr4cza changed the title [Kotlin-Spring] add Kotlin based Spring-cloud openfeign generator [Kotlin-Spring] add Kotlin based Spring Cloud OpenFeign generator Mar 25, 2023
@gr4cza gr4cza force-pushed the kotlin-spring-cloud-client branch from d71a5bf to b76cb34 Compare March 26, 2023 19:53
@gr4cza
Copy link
Contributor Author

gr4cza commented Mar 27, 2023

@wing328 can you please take a look on this one?

@gr4cza gr4cza force-pushed the kotlin-spring-cloud-client branch from e282382 to 9604f29 Compare March 29, 2023 21:06
@gr4cza
Copy link
Contributor Author

gr4cza commented Apr 5, 2023

I would appreciate if some of you could take a look on it @jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03). I would really love to use this with the next version.

@wing328 wing328 added this to the 6.6.0 milestone Apr 18, 2023
@gr4cza gr4cza force-pushed the kotlin-spring-cloud-client branch from e82c703 to 100771d Compare April 18, 2023 09:43
@gr4cza gr4cza force-pushed the kotlin-spring-cloud-client branch from 100771d to e249b6b Compare April 18, 2023 21:20
@wing328 wing328 merged commit 98c2794 into OpenAPITools:master Apr 24, 2023
46 of 47 checks passed
@gr4cza gr4cza deleted the kotlin-spring-cloud-client branch April 24, 2023 08:02
@JanGroot
Copy link

Love the addition, I am a little confused though.
I'd expect a client to be part of the main "kotlin" generator, and spring-cloud then as one of the options beside the
jvm-http4, jvm-retrofit etc.

Now it's part of the server code and ALSO generates the client.

@gr4cza

tiffmaelite added a commit to tiffmaelite/openapi-generator that referenced this pull request Jun 5, 2023
wing328 pushed a commit that referenced this pull request Jun 6, 2023
fmoraespadtec pushed a commit to padteclab/openapi-generator that referenced this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants