Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpp-qt5] client response headers and validation of properties for client and server #1508

Merged

Conversation

etherealjoy
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

  • Add checking of required properties for models
  • Add Header extraction for client

@stkrwork @MartinDelille @fvarose @ravinikam

Improve some checks for serialization
@etherealjoy etherealjoy changed the title [cpp-qt5] validation of properties for client and server [cpp-qt5] client response headers and validation of properties for client and server Nov 21, 2018
@etherealjoy etherealjoy added this to the 4.0.0 milestone Nov 21, 2018
Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (but I've not tested/used the change locally)

@etherealjoy etherealjoy merged commit 308515b into OpenAPITools:4.0.x Nov 29, 2018
@etherealjoy etherealjoy deleted the cpp-qt5-add-header-and-validation branch November 30, 2018 20:27
@wing328
Copy link
Member

wing328 commented Jan 2, 2019

@etherealjoy thanks for the contribution, which has been included in the 4.0.0-beta release: https://twitter.com/oas_generator/status/1079727020374806529.

Happy New Year and looking forward to more collaboration and contributions in 2019!

A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
…ient and server (OpenAPITools#1508)

* Add validation of required properties
Add Header extraction for client
* Remove some todos
* Add Test for Store API
Improve some checks for serialization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants