[C#] Fix non-nullable enums on operation parameters not compiling #1543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-processed to correctly mark them as enumerations. The api.mustache C# template now marks parameters as nullable when they're non-required enums.
…interface of the auto-generated C# Apis.
…uplicated nullable question marks for primitive types.
wing328
changed the title
wing328
changed the title
|
@rubms as discussed, we'll focus on the refactored C# client moving forward and will add better nullable support (which may undo some of the changes in this request) |
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
…arameters not compiling (OpenAPITools#1543) * Run ./bin/utils/ensure-up-to-date to re-generate samples run in the CI. * Fixed issue OpenAPITools#1531. Now in C# operation parameters are post-processed to correctly mark them as enumerations. The api.mustache C# template now marks parameters as nullable when they're non-required enums. * OpenAPITools#1531 Added fix for enum, non-required parameters to the interface of the auto-generated C# Apis. * Fixed error with the development of ticket OpenAPITools#1531, which duplicated nullable question marks for primitive types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.4.x,4.0.x. Default:master.C.C. @mandrean (2017/08) @jimschubert (2017/09)
Description of the PR
Fixed issue #1531 which caused enums used as non-required operation parameters to generate a C# code that does not compile. The reason for the error was that these enums were not generated as
Nullablebut they where being assignednulland compared tonull.I have fixed the error by:
csharpapi.mustachetemplate, that adds a?after parameter data types when the parameter is non-required and non-nullable.isEnumandisNullableproperties of operation parameters in the post-process performed inAbstractCsharpCodegen.