Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 3.3.4 release #1583

Merged
merged 3 commits into from
Nov 30, 2018
Merged

Prepare 3.3.4 release #1583

merged 3 commits into from
Nov 30, 2018

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Nov 30, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Prepare 3.3.4 release

@wing328 wing328 added this to the 3.3.4 milestone Nov 30, 2018
@wing328
Copy link
Member Author

wing328 commented Nov 30, 2018

Shippable job passed via https://app.shippable.com/github/OpenAPITools/openapi-generator/runs/4440/summary/console

Travis failure due to installation of stack, dart (not related to this PR)

@wing328 wing328 merged commit 2f4dc9a into master Nov 30, 2018
@wing328 wing328 deleted the 3.3.4-prepare branch November 30, 2018 17:00
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
* update release version

* update doc for 3.3.4 release

* comment out stack installation due to error in travis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant