Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kotlin-client][multiplatform] Added support enum query parameter #16327

Merged

Conversation

YusukeOba
Copy link
Contributor

#13404

The above PullRequest now outputs normal code when an enum exists in the query parameter.
However, it was not supported by the kotlin-client multiplatform library.

With my PR, the kotlin-client multiplatform library now outputs correct code with query parameters with enums as well.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@YusukeOba
Copy link
Contributor Author

@YusukeOba YusukeOba changed the title [kotlin-client][multiplatform] Add enum query parameter [kotlin-client][multiplatform] Added support enum query parameter Aug 15, 2023
@wing328
Copy link
Member

wing328 commented Aug 15, 2023

@wing328
Copy link
Member

wing328 commented Aug 15, 2023

LGTM. Thanks for the PR.

@wing328 wing328 merged commit 2e17653 into OpenAPITools:master Aug 15, 2023
55 of 56 checks passed
@wing328 wing328 added this to the 7.0.0 milestone Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants